pelias / whosonfirst

Importer for Who's on First gazetteer
MIT License
27 stars 42 forks source link

anchor WOF_NAMES_REGEX #470

Closed missinglink closed 5 years ago

missinglink commented 5 years ago

anchor WOF_NAMES_REGEX to prevent matching properties such as "label:eng_x_preferred_placetype"

I noticed that we are importing the label:eng_x_preferred_placetype property due to a regex error.

missinglink commented 5 years ago

@Joxit FYI I just noticed this subtle bug, I think this fix is correct?

missinglink commented 5 years ago

Hmm yes, but they are currently being indexed as aliases for default so it should be fine, I'm open to adding that back if it's an issue.

missinglink commented 5 years ago

I had to use admin privileges to merge this because the Travis integration showed as yellow despite the build being green on Travis 🤷‍♂