search

pelias / whosonfirst

Importer for Who's on First gazetteer
MIT License
27 stars 42 forks source link

Fix ignoring dataHost and maxDownloads options #484

Closed loadit1 closed 4 years ago

loadit1 commented 4 years ago

Summary of changes:

  1. Fix ignoring option dataHost while call sqlite_download.sh
  2. Update README to show correct example of dataHost URL
  3. Fix ignoring option maxDownloads in sqlite_download.js
loadit1 commented 4 years ago

Hi! Any updates on this small PR? I hope it can be merged without any issues as it's just small fix.

orangejulius commented 4 years ago

Hi @loadit1,

I just rebased this PR against the latest changes in the master branch and did a little cleanup. I think it's good to go, but will do a little bit more testing before merging! Thanks for taking the time to submit it.

orangejulius commented 4 years ago

Hi! We've done a bunch of housecleaning and as of #487 this PR should no longer be needed: we've removed a lot of downloader code and all the code that remains uses the dataHost configuration variable.

If there's anything that still doesn't work let us know and open an issue! :pray: