search

pelias / whosonfirst

Importer for Who's on First gazetteer
MIT License
28 stars 43 forks source link

Add tests for module exports #500

Closed orangejulius closed 4 years ago

orangejulius commented 4 years ago

This is a PR into #487 which adds some unit tests covering the shared resources exported by this module. We've been bitten many times in the past by removing code and forgetting to update index.js. This should help with that going forward.

It also fixes some that were just recently missed :)

orangejulius commented 4 years ago

@Joxit I think your PR has become the new master branch :grin:

orangejulius commented 4 years ago

If we merge this PR and #498 then your PR should be good to go. It should be a nice big new major version!

Joxit commented 4 years ago

Ha ha yes, this was a nice catch :sweat_smile:

Here we go ! The PR master is now the master :rocket: :full_moon: