search

pelias / whosonfirst

Importer for Who's on First gazetteer
MIT License
28 stars 43 forks source link

unit test failure with pelias/model upgrade #520

Closed missinglink closed 3 years ago

missinglink commented 3 years ago

when working on an unrelated feature I noticed that updating pelias/model resulted in a broken test.

I believe this is due to https://github.com/pelias/config/pull/135 removing a duplicate entry for continent?

@orangejulius could you please sanity check this for me?

    operator: deepEqual
    expected: 17
    actual:   16
    at: DestroyableTransform.<anonymous> (/Users/peter/code/pelias/whosonfirst/test/readStreamTest.js:123:11)
    stack: |-
           Error: should be deeply equivalent
             at Test.assert [as _assert] (/Users/peter/code/pelias/whosonfirst/node_modules/tape/lib/test.js:304:54)
             at Test.bound [as _assert] (/Users/peter/code/pelias/whosonfirst/node_modules/tape/lib/test.js:91:32)
             at Test.tapeDeepEqual (/Users/peter/code/pelias/whosonfirst/node_modules/tape/lib/test.js:545:10)
             at Test.bound [as deepEquals] (/Users/peter/code/pelias/whosonfirst/node_modules/tape/lib/test.js:91:32)
             at DestroyableTransform.<anonymous> (/Users/peter/code/pelias/whosonfirst/test/readStreamTest.js:123:11)
             at DestroyableTransform.emit (node:events:381:22)
             at finishMaybe (/Users/peter/code/pelias/whosonfirst/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:624:14)
             at endWritable (/Users/peter/code/pelias/whosonfirst/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:643:3)
             at DestroyableTransform.Writable.end (/Users/peter/code/pelias/whosonfirst/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:571:22)
             at Through2.onend (/Users/peter/code/pelias/whosonfirst/node_modules/through2-filter/node_modules/readable-stream/lib/_stream_readable.js:577:10)
missinglink commented 3 years ago

hmm... actually I think this has something to do with my local env pelias.json listing a WOF file