search

pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

made missing data file non-fatal #102

Closed trescube closed 7 years ago

trescube commented 7 years ago

References pelias/whosonfirst#209

orangejulius commented 7 years ago

Can we revert this? We decided a while back that all admin lookup file load failures should be fatal to protect against admin lookup failing silently. It's better to have to figure out what's wrong with the data after a loud build failure.

trescube commented 7 years ago

We could, but there are 2 types of failures:

In the former case, sure, since that's the users' problem. In the latter case, I'd prefer to keep loading since it seems unfair to punish users who did everything right and there's a WOF bundles failure.

We can certainly discuss further though.

orangejulius commented 7 years ago

Yeah, that's a good point. I do know that we've had our builds delayed for several weeks due to bundle issues, which is super annoying. On the other hand, with this change in, every build could potentially have any major city (except one we have acceptance tests for) lose admin data, and we wouldn't know. Let us discuss!!

orangejulius commented 7 years ago

Maybe the solution is a --ignore-missing flag (the solution to every problem seems to be a flag). That way, builds can by default ensure integrity, but if there is a legit bundle issue, there is a way for people to work around it.

trescube commented 7 years ago

How about a flag in the config for fatalities? It's not a big deal for our builds since we can wait for bundle fixes but users may not be that willing.

trescube commented 7 years ago

I'd prefer to make missing files non-fatal by default so users don't have to read any additional docs but specify for our builds. It'll cut down on gitter chatter.