search

pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

New Admin Lookup strategy has surfaced many WOF records with incorrect hiearchies #156

Closed orangejulius closed 5 years ago

orangejulius commented 7 years ago

After https://github.com/pelias/wof-admin-lookup/pull/143 we now have an awesome and much faster way of doing admin lookup. However, it relies more on the hierarchies of individual records, rather than doing point-in-polygon across all layers itself and effectively bypassing the WOF hierarchy. As a result many records that possibly never had correct hierarchies are now causing problems.

Examples

Erbil, Iraq

http://pelias.github.io/compare/#/v1/search%3Ftext=Erbil,%20Iraq image https://whosonfirst.mapzen.com/spelunker/id/421200817/ image

Bourail, New CAledonia

http://pelias.github.io/compare/#/v1/search%3Ftext=Bourail image https://whosonfirst.mapzen.com/spelunker/id/890438255/

missinglink commented 7 years ago

I have recently noticed that many hierarchies which were previously in the data are no longer there.

related: https://github.com/whosonfirst-data/whosonfirst-data/issues/954

orangejulius commented 5 years ago

Both of these cases have been fixed with WOF updates over the years. While we'll never get every hierarchy correct, we're well past the point of considering this a serious issue overall. If we do find more problematic hierarchies, we can handle them with individual issues here or in the whosonfirst repos