search

pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

support boroughs #257

Open missinglink opened 5 years ago

missinglink commented 5 years ago

PR https://github.com/pelias/lastline/pull/2 allows for borough placetypes to be imported additionally to the locality placetype.

It looks like there will need to be some minor edits made here to support this new functionality.

The file https://github.com/pelias/wof-admin-lookup/blob/master/src/usePostalCity.js contains some code which is tied specifically to the locality placetype which will need to be adjusted.

I believe https://github.com/pelias/wof-admin-lookup/blob/master/src/postalCityMap.js is fine as-is, although the code comment lists only 5 columns, none of which are the placetype, whereas it looks like placetype is being recorded in the lastline repo here https://github.com/pelias/lastline/blob/master/src/placeholderLookup.js

This PR is to do an end-to-end evaluation of using additional placetypes and to test it out for boroughs.