search

pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

make postal cities more placetype agnostic, add tests for boroughs #282

Closed missinglink closed 4 years ago

missinglink commented 4 years ago

@orangejulius this is a PR to make the 'postal cities' code more generic so it can handle boroughs.

orangejulius commented 4 years ago

Oh yeah, this is much better.

In the latest build I noticed that the code I recently added was too conservative. It will fail to add postal cities admin records in too many cases. With this PR and a change to revert my previous PR, it looks like we can handle boroughs while ensuring we used postal cities data in more cases!

So feel free to merge, unless you want to add something else.

:shipit: