pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

Revert duplicate id protection #283

Closed orangejulius closed 4 years ago

orangejulius commented 4 years ago

This protection was too conservative, and would cause many records to not benefit from postal cities data.

A new test case for one of those situations is included, which now passes with this change and https://github.com/pelias/wof-admin-lookup/pull/282

This PR includes #282 and will be rebased once it's merged

missinglink commented 4 years ago

I seem to use 'burough' and 'borough' spelling interchangeably in the code comments, not a big deal but I noticed during the review ;)