search

pelias / wof-admin-lookup

Who's on First Admin Lookup for the Pelias Geocoder
https://pelias.io
MIT License
9 stars 24 forks source link

Nl postalcity #299

Closed emacgillavry closed 4 years ago

emacgillavry commented 4 years ago

Hi there,

:wave: Following up on the conversations over on Gitter with @orangejulius regarding postal cities lookup for the Netherlands, I did some work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change :rocket:

OpenAddresses derives the address data from the Dutch key register Basisadministratie Adressen en Gebouwen, or simply BAG for short. On top of addresses, it provides a link to woonplaatsen or localities that are used in postal addresses. This changes creates an explicit link between the addresses from OpenAddresses and the official localities as much as these are already available in WOF.

Here's what actually got changed:

Here's how others can test the changes :eyes:

Compare the outcome with the addresses as can be found at BAG Viewer from the Dutch national mapping and cadastre agency, Ḱadaster. For example, "Ganzebloemstraat 37, Groningen" returns the out-dated locality of Noorddijk whilst the BAG currently uses Groningen as the current woonplaats.

orangejulius commented 4 years ago

Hi @emacgillavry, Awesome to see this!

Just to make sure I understand correctly, you generated the changes to NLD.tsv by running our lastline importer with OpenAddresses data for the Netherlands, correct? Did you have to make any changes to the lastline code or did it work out of the box?

As long as we or anyone else will be able to re-run the lastline build to replicate the data you've added here, everything should be good to go! Thanks again for the work here.

emacgillavry commented 4 years ago

No changes were made to the lastline code to generate the NLD.tsv. The input comes from the OpenAddresses source indeed, where we first deduplicated the postal codes.

orangejulius commented 4 years ago

Thanks again for this PR! Sorry for the brief delay, I was out on a little holiday :)

I just did some git/github magic to update your PR with our commit message format to generate a new release. I'll also make sure the OSM/OA/csv-importer repos all pick up this change once it's merged.

:pray: