pelias / wof

WhosOnFirst tools
3 stars 2 forks source link

find cmd via child_process do not need semicolon escape #6

Closed Joxit closed 4 years ago

Joxit commented 4 years ago

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change :rocket:

When I use the fs sub command, it fails with this message:

$ wof fs export data
find: missing argument to `-exec'

Here's what actually got changed :clap:

I've remove the semicolon escape from the spawn, it seems to be the cause of the issue. Check if it's also ok for you.

I tried on debian jessie and buster.

missinglink commented 4 years ago

Good catch, this also wasn't working on OSX, but works great with this PR 🎉

missinglink commented 4 years ago

Published as npm @whosonfirst/wof@0.8.0