pelican-dev / docs

Documentation site for Pelican Panel
https://docs-peli.vercel.app
27 stars 27 forks source link

Add continuity to height #11

Closed cyanide1x closed 5 months ago

cyanide1x commented 6 months ago

Adds a minimum height to the main wrapper that calculates the height needed to start at the full device height with respect to the size of the top navigation bar.

lancepioch commented 6 months ago

@cyanide1x Would you be able to share a screenshot of before and after?

cyanide1x commented 6 months ago

BEFORE: https://github.com/pelican-dev/docs/assets/76759085/a5b400c5-94c2-4286-abc7-e6bcceb3cfe7

AFTER: https://github.com/pelican-dev/docs/assets/76759085/7ddd1d04-dfd8-4103-a9d1-d3565fab304a

TLDR; It sets a minimum height so that when switching between pages, if the content itself doesn't take up at least a full page it will still fill the whole device height with empty space so the page doesn't randomly show parts of the footer.

lancepioch commented 5 months ago

Thanks!