search

pelican-dev / panel

https://pelican.dev
GNU Affero General Public License v3.0
809 stars 82 forks source link

Added description and notes text fields to Nodes #450

Closed Poseidon281 closed 3 months ago

Poseidon281 commented 3 months ago

Suggested: Here

RMartinOscar commented 3 months ago

What's the difference between description and notes ?

NerdsCorp commented 3 months ago

I don't think there would be a major difference. Is there already an option for a description on a node?

RMartinOscar commented 3 months ago

I don't think there would be a major difference. Is there already an option for a description on a node?

The field is in place since pterodactyl but currently never used You can see it here

NerdsCorp commented 3 months ago

@RMartinOscar the difference in my thought is I'd like to add notes, not just a description. Like if it's in the cloud or in my home lab at home. Also, last time I serviced that particular node and when it was put into service. I think a description would work just as well as long as it allowed you to add a few lines, not just a single line. I think the one pterodactyl had was great!

RMartinOscar commented 3 months ago

@RMartinOscar the difference in my thought is I'd like to add notes, not just a description. Like if it's in the cloud or in my home lab at home. Also, last time I serviced that particular node and when it was put into service. I think a description would work just as well as long as it allowed you to add a few lines, not just a single line. I think the one pterodactyl had was great!

The fact that its a text field means its limited to 65 535 chars imo that's plenty enough

NerdsCorp commented 3 months ago

@RMartinOscar i did not know that! I think the one from pterodactyl would be just fine! 😁

Poseidon281 commented 3 months ago

Using description like Pterodactyl instead of Notes

If the Pelican Team wants me to I will switch the field to description, but I think there is a real difference between notes and description. I would have used description if there was not. So for now I am going with notes.

lancepioch commented 3 months ago

Pull requests must be associated with an existing issue.