pelican-eggs / Palworld-Config-Parser-Tool

A simple aplication that edits the Palword server config based on variables
MIT License
13 stars 11 forks source link

Update 0.1.5.0 - add new variable bShowPlayerList #3

Closed Ballaual closed 6 months ago

Ballaual commented 6 months ago

With patch 0.1.5.0 they have added new config variable "bShowPlayerList" as boolean to toggle wether the player list should be appear ingame when pressed ESC or not.

NOTE: I currently do not know how this behaves with a existing config as the value has not been added to the config or example config either with the patch..

The new variable can be found at the docs: https://tech.palworldgame.com/settings-and-operation/configuration

Is it possible to automatically download the current config parser on startup, as it remains an older version if not updating it manually?

Ballaual commented 6 months ago

adding it manually behind the banlisturl variable ,bShowPlayerList=True will work

image

image

QuintenQVD0 commented 6 months ago

Automaticaly updating will not work as offial eggs can not download for external repos. I talk with parker about this.

QuintenQVD0 commented 6 months ago

But when reinstalliling a new config will generate and a new parser will be downloaded.

Ballaual commented 6 months ago

But when reinstalliling a new config will generate and a new parser will be downloaded.

also thought this but my parser is still 1.0.9 after reinstalling. Latest version has been 1.0.10. Or was it missing in the eggs repo?

QuintenQVD0 commented 6 months ago

But when reinstalliling a new config will generate and a new parser will be downloaded.

also thought this but my parser is still 1.0.9 after reinstalling. Latest version has been 1.0.10. Or was it missing in the eggs repo?

It downloads from the eggs repo. That is still at 1.0.9

Ballaual commented 6 months ago

But when reinstalliling a new config will generate and a new parser will be downloaded.

also thought this but my parser is still 1.0.9 after reinstalling. Latest version has been 1.0.10. Or was it missing in the eggs repo?

It downloads from the eggs repo. That is still at 1.0.9

makes sense :D

QuintenQVD0 commented 6 months ago

But when reinstalliling a new config will generate and a new parser will be downloaded.

also thought this but my parser is still 1.0.9 after reinstalling. Latest version has been 1.0.10. Or was it missing in the eggs repo?

It downloads from the eggs repo. That is still at 1.0.9

makes sense :D

I will append the 1.0.11 to the rcon eggs PR. So the proton egg also can start to work.

Ballaual commented 6 months ago

i will test the 1.0.11 before merging the egg if it adds the variable correctly to the config.

QuintenQVD0 commented 6 months ago

i will test the 1.0.11 before merging the egg if it adds the variable correctly to the config.

It wont add it at all. Its a Safety I build in. But on reinstall the egg makes a backup of the config. Or if you just remove it the parser will take the default one and paste it in to there.

Ballaual commented 6 months ago

so now it works (if you setup the ptero variable correctly ;) however the closing bracket gets removed after updating the ini. Tbh never checked before if this also happened with older versions or not. Just want to let u know that this happens but does not seem to affect anything yet, server starts and the variables works as set.

image image

QuintenQVD0 commented 6 months ago

so now it works (if you setup the ptero variable correctly ;) however the closing bracket gets removed after updating the ini. Tbh never checked before if this also happened with older versions or not. Just want to let u know that this happens but does not seem to affect anything yet, server starts and the variables works as set.

image image

If you do not put it at the end then it stays afbeelding

QuintenQVD0 commented 6 months ago

@Ballaual Can you make a PR and edit the example in the readme to put it before the BanListURL? and clearly mention it can not be at the end. I can not aprove my self made PR ;)

Ballaual commented 6 months ago

@Ballaual Can you make a PR and edit the example in the readme to put it before the BanListURL? and clearly mention it can not be at the end. I can not aprove my self made PR ;)

will do when back home ~1h

Ballaual commented 6 months ago

what do you think about adding this?

https://github.com/Ballaual/Palword-server-config-parser/commit/e10eb9634031680f6c07f96e05a195965ae5e15a

QuintenQVD0 commented 6 months ago

what do you think about adding this?

Ballaual@e10eb96

and what if the last of content is a newline?

and it wont mather as it is removed after parsing as if you edit the banlist url (if that is the last one) then you do not have that issue

QuintenQVD0 commented 6 months ago

wait I see banlist also has this issue, it seems my clice logic is wrong as it does not check for a closing )

Ballaual commented 6 months ago

;) i mean usually u wont edit thr banlidt at all so yea it might never happen. but just in csse it should br handled somewhere ^^

and i guess it might be also possible to add new variables if not already exist when checking if its there or not.

QuintenQVD0 commented 6 months ago

;)

your maybe a good solution and I will keep it in mind but the clice logic should just work for that

Ballaual commented 6 months ago

;)

your maybe a good solution and I will keep it in mind but the clice logic should just work for that

in the meantime still update the readme then yes?

Ballaual commented 6 months ago

;)

your maybe a good solution and I will keep it in mind but the clice logic should just work for that

in the meantime still update the readme then yes?

i asked nothing ok 🤣

QuintenQVD0 commented 6 months ago

I think I got it working, you have time to test it?

Ballaual commented 6 months ago

sure

QuintenQVD0 commented 6 months ago

sure

https://github.com/QuintenQVD0/Palword-server-config-parser/commit/df621dadd954f05b4b593034a345826064405737 In my local setup it did work, now lets hope it still does in production and with the actual game

Ballaual commented 6 months ago

y local setup it did work, now lets hope it still does in production and with the actual game

will download the 1.0.12 and let u know

Ballaual commented 6 months ago

looks good i would say.

before (add manual): image

after (using 1.0.12): image image image

changing the panel value back to false and restarting also applies the value and the bracket is still there. Ingame both version (enabled/disabled) work as they should! and the rest also works as before 🥳