Closed BenasPaulikas closed 1 year ago
This seems to be an issue with the install script. It's looking for a browser_download_url
key in the JSON response, but no such key exists. This appears to be because the assets
section is missing, at least on the release I'm testing (latest).
# echo ${LATEST_JSON}
{ "url": "https://api.github.com/repos/mumble-voip/mumble/releases/57266743", "assets_url": "https://api.github.com/repos/mumble-voip/mumble/releases/57266743/assets", "upload_url": "https://uploads.github.com/repos/mumble-voip/mumble/releases/57266743/assets{?name,label}", "html_url": "https://github.com/mumble-voip/mumble/releases/tag/v1.4.230", "id": 57266743, "author": { "login": "Krzmbrzl", "id": 12751591, "node_id": "MDQ6VXNlcjEyNzUxNTkx", "avatar_url": "https://avatars.githubusercontent.com/u/12751591?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Krzmbrzl", "html_url": "https://github.com/Krzmbrzl", "followers_url": "https://api.github.com/users/Krzmbrzl/followers", "following_url": "https://api.github.com/users/Krzmbrzl/following{/other_user}", "gists_url": "https://api.github.com/users/Krzmbrzl/gists{/gist_id}", "starred_url": "https://api.github.com/users/Krzmbrzl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Krzmbrzl/subscriptions", "organizations_url": "https://api.github.com/users/Krzmbrzl/orgs", "repos_url": "https://api.github.com/users/Krzmbrzl/repos", "events_url": "https://api.github.com/users/Krzmbrzl/events{/privacy}", "received_events_url": "https://api.github.com/users/Krzmbrzl/received_events", "type": "User", "site_admin": false }, "node_id": "RE_kwDOABWQx84DadI3", "tag_name": "v1.4.230", "target_commitish": "master", "name": "v1.4.230", "draft": false, "prerelease": false, "created_at": "2022-01-02T17:16:22Z", "published_at": "2022-01-17T08:31:03Z", "assets": [ ], "tarball_url": "https://api.github.com/repos/mumble-voip/mumble/tarball/v1.4.230", "zipball_url": "https://api.github.com/repos/mumble-voip/mumble/zipball/v1.4.230", "body": "This is the first stable release of the 1.4 series.\r\n\r\nRelease announcement: https://www.mumble.info/blog/mumble-1.4.230/", "reactions": { "url": "https://api.github.com/repos/mumble-voip/mumble/releases/57266743/reactions", "total_count": 8, "+1": 0, "-1": 0, "laugh": 0, "hooray": 5, "confused": 0, "heart": 0, "rocket": 3, "eyes": 0 } }
# echo ${LATEST_JSON} | jq .assets
[]
Sure enough, if I look at their latest release there is only the default source code blobs in the assets: https://github.com/mumble-voip/mumble/releases/tag/v1.4.230
Comparing this to an older release the artifacts used to be in the Assets: https://github.com/mumble-voip/mumble/releases/tag/1.3.0
The install script will have to be updated to handle whatever change they've made in where they're publishing the artfiacts.
Filed https://github.com/mumble-voip/mumble/issues/5451. Looks like the latest release only came out 13 hours ago.
They manually push the releases so this will self resolve eventually
Looks like the filename format changed so this will still need to be fixed in the install script.
Old download was: https://github.com/mumble-voip/mumble/releases/download/1.3.4/mumble-1.3.4.tar.gz
New download is: https://github.com/mumble-voip/mumble/releases/download/v1.4.230/mumble_server-1.4.230.x64.linux
Notably the version number now also includes a v
That's annoying as we would have to support both old and new methods. I can take a look later today to see if that's the case.
Pretty sure we grep for a match so additional v should not affect it
They renamed the file from murmur_static to mumble_server hence why the match can't find it when grepping
Furthermore, they are no longer releasing static server builds. Thus, we'd have to build from the source. Ref https://github.com/mumble-voip/mumble/issues/5453#issuecomment-1015133736
My understanding of that comment is that they publish dynamically linked binaries instead of statically linked binaries. Doesn't that just mean that the binary is not self contained and requires dependencies to be installed? Since we're shipping the docker image with the egg we have control over the environment and we can install whatever dependencies we want.
Installing from source is an option, but I don't think a requirement?
We can use a dynamic one once we figure out what's required and how their releases actually are going to work. There were many opened issues for dynamic builds and missing submodules. Their latest release wasn't the smoothest, so once they clear it all up, we could take a look at how it should work in the future
Does anyone get the following when trying to set to versions prior to 1.4 of mumble? I would think the script should work for previous versions that still have the murmur-static assets. Note: This is on 1.3.1 as the template on master is set to this...
Closes as https://github.com/pterodactyl/panel/pull/4437 is merged
Panel Version
1.6.6
Wings Version
1.5.3
Service
stock_eggs/voice-servers/egg-mumble-server
Modified
No, I did not modify the egg
Expected Behavior
No error.
Actual Behavior
:/home/container$ ./murmur.x86 -fg /entrypoint.sh: eval: line 1: ./murmur.x86: not found
Steps To Reproduce
Install egg
Install logs
above