pelican-eggs / eggs

Service eggs for the pterodactyl panel
MIT License
2.85k stars 2.32k forks source link

[Feedback]: Remove "Buy me a coffee" Link from this repo and let Egg creaters add their own donation Link #2000

Closed gOOvER closed 1 year ago

gOOvER commented 1 year ago

Expected Behavior

Every Egg Author, which push to this repro should be able to provide their own Donation Link

Actual Behavior

ATM Only Parker have a Donation Link for "Buy me a Coffey"

gOOvER commented 1 year ago

The development of Egg is not always self-evident and there is work behind it. So it can't be that only the repo owner has a donation link.

Every Egg author should be allowed to add their own donation link so that their work is appreciated if people want to appreciate it.

This is where an official Egg Repo comes into play again, without any single person having it under him, but that it is assigned to the pterodactyl project.

parkervcp commented 1 year ago

Nobody has ever asked or tried adding a donation link. I had mine there from the beginning for when I was making eggs alone and had to buy many games to test them out.

As the repo has grown and I have gotten PR's from more people to add eggs it has expanded beyond what I ever imagined. I had added more maintainers to help manage incoming PR's. There are plans on expanding some of the tooling around the repo so make PR's more "automated" on the maintainer end. Hopefully that will make the process easier for us.

Honestly, adding a maintainer and donation link is probably a better approach to the egg readme's than removing my link outright.

gOOvER commented 1 year ago

copy and pasted from Discord:

Your repo and your decision; but in my opinion your link is always visible first and you also know that 98% never read the readme. So at least an equal opportunity would be created

lilkingjr1 commented 1 year ago

Unfortunately, this is where I again would like to give my opinion that if the Pterodactyl community is to have an "official" repo of eggs, it should really be migrated to the generic Pterodactyl Github account as a separate repo (separate from the even more official seeding folder of the project; unless that is desired).

Short of that, it's my personal opinion that:

But that's just an opinion and not a reality. If parker wants to just take all the PRs he's gotten over the years and just own them outright, he has full right to. I just think one's more fair than the other.

On a side note, I think taking the HTML template I use on my readme's to indicate authors and maintainers and applying it to the whole repo could be nice. Could even modify it to include donation links.

gOOvER commented 1 year ago

Unfortunately, this is where I again would like to give my opinion that if the Pterodactyl community is to have an "official" repo of eggs, it should really be migrated to the generic Pterodactyl Github account as a separate repo (separate from the even more official seeding folder of the project; unless that is desired).

Short of that, it's my personal opinion that:

  • The front page donation link should just be removed
  • Any eggs parker originally made should have the donation link added to their readme's
  • Any eggs that have active maintainers or creators should have the right to PR their personal donation link to, effectively, their egg's readme

But that's just an opinion and not a reality. If parker wants to just take all the PRs he's gotten over the years and just own them outright, he has full right to. I just think one's more fair than the other.

On a side note, I think taking the HTML template I use on my readme's to indicate authors and maintainers and applying it to the whole repo could be nice. Could even modify it to include donation links.

Exactly what I think all along and also have long suggested.

Parker, nothing against you, but as mentioned your link is very dominant here, that is, everyone sees it first and you also do not really much for some time. if there are donations, they go to you. (Without really having had work)

I would ask you to finally turn the whole thing into an official repo under the administration of pterodactyl.

On the other hand, you have to admit that everyone is pinging you in Discord about Eggs, even when you haven't developed it . Because everyone only sees "PARKERS REPO".

@lilkingjr1 The HTML thing looks really great on Github, but when you dl the Readme, there is only html code and its unreadble in my eyes. In my opinion the readme should only be contain markdown. but tastes are different and it is only my personal feeling

ZaxLofful commented 1 year ago

Just my two cents...I agree that this repo should be moved to the official Pterodactyl GitHub account.

At the same time, this repo should just be default in Pterodactyl.

Everything in this repo should just show up in Pterodactyl by default....Why should I have to add all these Eggs myself?

Its not like the JSON configs are large by any means, just include everything from the start.

QuintenQVD0 commented 1 year ago

Just my two cents...I agree that this repo should be moved to the official Pterodactyl GitHub account.

At the same time, this repo should just be default in Pterodactyl.

Everything in this repo should just show up in Pterodactyl by default....Why should I have to add all these Eggs myself?

Its not like the JSON configs are large by any means, just include everything from the start.

The panel repo mainains like 10 eggs, we way more.

Northwave commented 1 year ago

As User I like the idea, in every fresh install i have to upload the eggs again and again

Everything in this repo should just show up in Pterodactyl by default....Why should I have to add all these Eggs myself?

QuintenQVD0 commented 1 year ago

fresh

All egg shipped with the panel pterodactyl are almost 100% guaranty to work. That is currently not with this repo

parkervcp commented 1 year ago

Per this request. I have removed my buymeacoffee link as that was the main concern.

As I had previously stated, I never told anyone they couldn't add their own donation link, as nobody ever asked or tried.

For the rest of the conversation, I will say that the amount of eggs I have in this repo would be unsustainable for the panel to keep in place. The sheer number of docker images and games that require fairly regular updates is already daunting.