search

pelican-eggs / eggs

Service eggs for the pterodactyl panel
MIT License
2.8k stars 2.31k forks source link

GoMint Support [Bedrock Edition] [Java 11] #827

Closed RealTriassic closed 3 years ago

RealTriassic commented 3 years ago

Please fill out the information bellow and remove from the line up Please understand how Pterodactyl works when you are requesting an egg. (ie. docker-compose doesn't work for a pterodactyl server)

Service: Minecraft

Does this expand an already existing service: Y

Link to game: https://gomint.io

Links for server downloads: https://github.com/gomint/gomint/releases

Links for install steps/docs: There are no docs for installing it at the moment, sadly, but running it is quite easy, on desktop it's just running one start.sh file [or start.cmd] and GoMint is running, running it requires the "Modules" folder to be downloaded, the contents of start.sh would be the Startup Command.

parkervcp commented 3 years ago

So looking at their repo and how they pack their files is annoying.

RealTriassic commented 3 years ago

So looking at their repo and how they pack their files is annoying.

Sorry

Soupertonic commented 3 years ago

Sorry

Don't be sorry for it! You're not a maintainer, you don't have to take any responsibility.

So looking at their repo and how they pack their files is annoying.

@parkervcp Would you like to propose another packing/distribution strategy?

parkervcp commented 3 years ago

Just a single zip with the modules folder in it.

Soupertonic commented 3 years ago

I don't know if you haven't noticed but GoMint releases do feature that. If you head over to the releases section of GoMint and choose let's say 1.0.0RC5, you can see that there's a file attached as asset called GoMint.Server.zip. Download, extract it and you'll discover three entries. start.sh, start.cmd and modules.

parkervcp commented 3 years ago

There is a server.zip in the release they have there. That is what i am saying here.

If if was just a single zip containing the modules and scripts I wouldn't have said anything

Soupertonic commented 3 years ago

What's the issue with unzip-ping the zipball, moving the modules directory out there and discarding the remainder?

parkervcp commented 3 years ago

So every other egg I have right now so far as I know doesn't need me to unzip 2 times to get the files. I was just calling it out as annoying.

Soupertonic commented 3 years ago

There must have been some misunderstandings on my side. I wasn't aware that the released zipball contained another zipball due to a broken pipeline. I understand your pain and took care of it. The release assets section now features two different flavors:

parkervcp commented 3 years ago

That actually helps out greatly.