pelican-eggs / games-standalone

Eggs for game servers that are standalone in their installation (ie. don't require 3rd party tools).
MIT License
25 stars 13 forks source link

Added Nazi Zombies: Portable egg #18

Open JordanPlayz158 opened 2 weeks ago

JordanPlayz158 commented 2 weeks ago

Description

The Nazi Zombies: Portable (NZ:P) egg is being added. This egg is for the dedicated server for the game Nazi Zombies: Portable, this game is based on the FTEQW. It targets a lot of platforms and as the name may suggest is a Call of Duty: Zombies (Nazi Zombies) de-make.

Checklist for all submissions

New egg Submissions

  1. [X] Does your submission pass tests (server is connectable)?
  2. [ ] Does your egg use a custom docker image?
    • [ ] Have you tried to use a generic image?
    • [ ] Did you PR the necessary changes to make it work?
  3. [X] Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. [X] Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. [X] You verify that the start command applied does not use a shell script
    • [ ] If some script is needed then it is part of a current yolk or a PR to add one
  6. [X] The egg was exported from the panel
JordanPlayz158 commented 2 weeks ago

Sorry about the 2 commits, went down the checklist and realized, I think there is an option to Squash then Merge though through github?

Also this was made with the Pterodactyl Panel at the moment (still waiting for stable pelican release), is that fine?

QuintenQVD0 commented 2 weeks ago

Sorry about the 2 commits, went down the checklist and realized, I think there is an option to Squash then Merge though through github?

Also this was made with the Pterodactyl Panel at the moment (still waiting for stable pelican release), is that fine?

rename the file to have the -pterodactyl in it like all eggs have now (as their now 2) and then I will append the converted egg here

JordanPlayz158 commented 1 week ago

Done!

Edit: wtf, just realized that git didn't recognize the mv as a remove but just a file added, interesting.

QuintenQVD0 commented 1 week ago

Done!

Edit: wtf, just realized that git didn't recognize the mv as a remove but just a file added, interesting.

Thats fine. Notthing you can do about that.

JordanPlayz158 commented 1 week ago

Yeah, I did remove it with the latest commit, haven't resolved that last conversation as I wanted input as to what you mean for it?

JordanPlayz158 commented 1 week ago

Even though all 3 were resolved, still says "Changes requested" gonna hit the "Re-request review button" even though I thought, once you resolved all of them, GitHub would automatically detect that

QuintenQVD0 commented 1 week ago

Even though all 3 were resolved, still says "Changes requested" gonna hit the "Re-request review button" even though I thought, once you resolved all of them, GitHub would automatically detect that

Yea no it is still github. I will do the needed but not until friday.

JordanPlayz158 commented 1 week ago

Alright, thank you! I appreciate all the time you have taken to look over the egg!

JordanPlayz158 commented 1 week ago

README updated!