pelican-eggs / minecraft

MIT License
51 stars 25 forks source link

[Bug]: Forge Enhanced/Generic egg install script does not point to the unix_args.txt #21

Closed LaiZBoi closed 1 month ago

LaiZBoi commented 2 months ago

Panel Version

1.0.0-beta6

Wings Version

1.0.0-beta3

Service

minecraft

Modified

No, I did not modify the egg

Expected Behavior

When I start the server, it should use the unix_args.txt file located in libraries/net/minecraftforge/forge/{forge version}/ and start.

Actual Behavior

When you press start, it doesn't see the unix_args.txt and wants to use a server.jar when there is no server.jar for forge 1.18+ and the server will not start.

Steps To Reproduce

Step 1: Create server using forge enhanced/generic egg. Step 2: Let server install Step 3: Start Server.

Install logs

https://pastebin.com/AqD8pPV0

spyderwan commented 1 month ago

hey, the command is given in the startup parameters under this line: Default Service Start Command just set it under the Startup Command line

here's the value to put in Startup Command : java -Xms128M -Xmx{{SERVER_MEMORY}}M -Dterminal.jline=false -Dterminal.ansi=true $( [[ ! -f unix_args.txt ]] && printf %s "-jar {{SERVER_JARFILE}}" || printf %s "@unix_args.txt" )

### message to those who update eggs: add this line to docker_images: "Java 21": "ghcr.io/pterodactyl/yolks:java_21",

LaiZBoi commented 1 month ago

You mean the startup like this? This is what it is currently set to. image And this is what it shows in console when I start the server. image The only way to get the server running at this moment is to copy unix_args.txt into the root server folder where server.properties is located.

spyderwan commented 1 month ago

you have to put the start line in the red square on the picture unknown

Just to be sure, you've just put the installation on top of an existing one ? because when I try a new installation and just modify the startup line, I don't have any problems on my side

both files are created directly in the root folder : unknown

LaiZBoi commented 1 month ago

That is the startup command. image These are the egg settings. image

I made a new server, with the egg and it booted up just fine. These are the files before startup image

And these are the files after. image

There must of been something I either overlooked or something with the modpacks that are being used by my user. The modpack is using 1.18.2 Forge and Java 18. Would that cause the issues im seeing? Thanks for all the help.

spyderwan commented 1 month ago

I can't reproduce your error, but it could be due to the forge version used, as the recommended version uses java 18 while the lastest uses java 21. (forge 1.18.2)

Or just that the server installation itself was faulty, making it impossible just to force a Reinstall Server, and that creating a new installation fixed the problem.