Fix entrypoint.sh permissions in dockerfiles

pelican-eggs / yolks

Docker images designed for use with Pterodactyl's Egg system.

MIT License

89 stars 248 forks source link

Fix entrypoint.sh permissions in dockerfiles #174

Closed kev626 closed 1 year ago

kev626 commented 1 year ago

Description

Fix #173

When starting Java containers (Java 17 tested) on the latest build (released <1 hour ago) the following error occurs indicating a permissions issue with the entrypoint file:

environment/docker: failed to start container: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/entrypoint.sh": permission denied: unknown

This PR resolves the permissions issue by executing a chmod command in each Dockerfile.

All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[x] Have you created a new branch for your changes and PR from that branch and not from your master branch?

parkervcp commented 1 year ago

This wasn't needed before as it was working. I don't believe it's needed now.

kev626 commented 1 year ago

Test the latest builds of the java_17 image. It is impossible to start and yields the error mentioned. The permissions of the file are not correct. Adding a chmod step to the dockerfile ensures that the permissions are always set correctly.

parkervcp commented 1 year ago

If they were broken I assume I would have more than a single person saying that.

kev626 commented 1 year ago

We have seen the exact same issue on 4 different machines and the number is growing as images are purged. The bad build was just produced about 1 hour ago.

GibsonHF commented 1 year ago

issue just started occurring recently. has to be with the new build

Goldragon747 commented 1 year ago

I'm seeing this issue as well

parkervcp commented 1 year ago

I am going to take this conversation to the issue and not the PR.

parkervcp commented 1 year ago

There is a better way to set it as executable that updating every docker file.

I still have issue because the ghcr.io/parkervcp/yolks:debian container was built at the same time with no issues.

I will close this while I inspect the issue

toster234 commented 1 year ago

If they were broken I assume I would have more than a single person saying that.

A customer reported this problem to me today, changing to Java 19 helped :)