pelican-eggs / yolks

Docker images designed for use with Pterodactyl's Egg system.
MIT License
89 stars 248 forks source link

Cleanup java images #175

Closed gOOvER closed 1 year ago

gOOvER commented 1 year ago

Description

All Submissions:

QuintenQVD0 commented 1 year ago

@gOOvER Edit: the cleanup is fine and the move to jammy.

I now see the issue that they introduced. does it work when you set it to bash and not sh and even more to the full path so /bin/bash instead of just sh or bash.

edit 2: Tomcat just set the entrypoint to https://github.com/docker-library/tomcat/pull/303/commits/55546d611e41cde189ba9e820c25cb5bf18a33f9

QuintenQVD0 commented 1 year ago

I see, this is comming because they have an entrypoint now in there images, see:

https://github.com/adoptium/containers/pull/392 https://github.com/adoptium/containers/commit/05b7f082746228466ceacf43dd0c21e9a0ba2b84#diff-f039b99538d3a63ca08a6fd9e5a9ff5f5a6108066c058902dacbea9b928e635f

gOOvER commented 1 year ago

@gOOvER Edit: the cleanup is fine and the move to jammy.

I now see the issue that they introduced. does it work when you set it to bash and not sh and even more to the full path so /bin/bash instead of just sh or bash.

edit 2: Tomcat just set the entrypoint to https://github.com/docker-library/tomcat/pull/303/commits/55546d611e41cde189ba9e820c25cb5bf18a33f9

dont Test IT, but this works fine for me.

what excact you mean with full path?

parkervcp commented 1 year ago

I'll pr a fix for the script perms instead of updating all this. That would fix this.

parkervcp commented 1 year ago

My PR #176 resolves this without editing all the Dockerfiles.