Added Bun Image - Githubissues

pelican-eggs / yolks

Docker images designed for use with Pterodactyl's Egg system.

MIT License

89 stars 248 forks source link

Added Bun Image #179

Closed ghost closed 1 year ago

ghost commented 1 year ago

Description

Added Bun Image

All Submissions:

[X] Have you ensured there aren't other open Pull Requests for the same update or change?
[X] Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

[X] Have you added your image to the Github workflows?
[X] Have you updated the README list to contain your new image?

QuintenQVD0 commented 1 year ago

Please use a coppy of our existing workflow files. Not something custom made.

QuintenQVD0 commented 1 year ago

Also your way of making the docker file does not match ours. Like build for arm64

ghost commented 1 year ago

Take a look now, I'm ready to improve/change anything.

QuintenQVD0 commented 1 year ago

Take a look now, I'm ready to improve/change anything.

I already made the needed changes, please build the image locally (or where you have it rn) the exact way as it is here as the emptying the entrypoint.sh of them may not be needed

ghost commented 1 year ago

I have built and test both images (latest and canary) and they work without any problems.

QuintenQVD0 commented 1 year ago

Now hope I did not mess up