pelican-eggs / yolks

Docker images designed for use with Pterodactyl's Egg system.
MIT License
89 stars 248 forks source link

Add libnss3 to nodejs #183

Closed Paultje52 closed 1 year ago

Paultje52 commented 1 year ago

Description

This PR adds libnss3 as an dependency to the docker file for node 18, 19 and 20. This dependency is needed to run puppeteer.

All Submissions:

QuintenQVD0 commented 1 year ago

Wy not the other nodejs images?

parkervcp commented 1 year ago

Honestly I already have a wings pr that fixes this issue that I am waiting on.

Paultje52 commented 1 year ago

Wy not the other nodejs images?

Because 16 will go EOL in less then a week and the versions before that are already EOL

Paultje52 commented 1 year ago

Honestly I already have a wings pr that fixes this issue that I am waiting on.

Great! Is it maybe possible to merge this PR and temporarily fix the issue? When your wings pr is merges, it can be removed. Maybe you can even remove more dependencies that are no longer needed 😄

QuintenQVD0 commented 1 year ago

This has to wait. I need to append an extra fix. Npm 10 released and it only supports nofejs 16 or up

QuintenQVD0 commented 1 year ago

Honestly I already have a wings pr that fixes this issue that I am waiting on.

libnss3 is a network security layer. How does that related to any wings pr?

gOOvER commented 1 year ago

i would remove all deprecated nodejs version.

QuintenQVD0 commented 1 year ago

i would remove all deprecated nodejs version.

I get it 100% we keep them to keep the packages with the image up to date. as a lot of nodejs version are EOL and I do know that

gOOvER commented 1 year ago

Then I would remove it; because at least in the EU, the provider of outdated software can be held liable. There is no "compatibility"

And if an app needs under Node 18, the person can take that into his responsibility and make an image himself.