Closed mattman107 closed 4 months ago
Forgive me for my ignorance, but I noticed in the games.yml file that it says
runs-on: ubuntu-latest
So I assumed that I had to make the Dockerfile using ubuntu like this
FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04
Do I have to use ubuntu or could I use a debian base instead?
Forgive me for my ignorance, but I noticed in the games.yml file that it says
runs-on: ubuntu-latest
So I assumed that I had to make the Dockerfile using ubuntu like this
FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04
Do I have to use ubuntu or could I use a debian base instead?
Its just what the workflow runs on. But keep in mind that we moved to debian 12 if possible.
Got it. I will change it to debian then.
So I wasn't able to get the github actions working, but I started doing testing manually building the container and uploading it to dockerhub. I have successfully gotten the egg to work properly using the container now in this PR.
Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.
Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.
This repo will become soon read only. All pr must be moved to their individual repo's
Are any PRs on hold until the whole Pelican restructure situation is figured out? I have been a bit out of the loop, but really excited to get a chance to it try out.
This repo will become soon read only. All pr must be moved to their individual repo's
Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?
Are any PRs on hold until the whole Pelican restructure situation is figured out? I have been a bit out of the loop, but really excited to get a chance to it try out.
This repo will become soon read only. All pr must be moved to their individual repo's
Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?
Yolks will stay 1 single yolks repo.
Are any PRs on hold until the whole Pelican restructure situation is figured out? I have been a bit out of the loop, but really excited to get a chance to it try out.
This repo will become soon read only. All pr must be moved to their individual repo's
Wait so there will no longer be a single unified yolk repository? In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?
Yolks will stay 1 single yolks repo.
Alright so this PR for the yolk is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?
Are any PRs on hold until the whole Pelican restructure situation is figured out? I have been a bit out of the loop, but really excited to get a chance to it try out.
This repo will become soon read only. All pr must be moved to their individual repo's
Wait so there will no longer be a single unified yolk repository? In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?
Yolks will stay 1 single yolks repo.
Alright so this PR for the yolk is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?
yes you are.
Description
Added a yolk for The Battle For Wesnoth game. Needed some specific libraries in the main container to run. I have never used Github actions/workflows before so please let me know if I did something wrong with that.
For this PR: https://github.com/parkervcp/eggs/pull/2863#issue-2229058331
All Submissions:
New Image Submissions: