search

pelican-plugins / search

Pelican plugin that adds site search capability
47 stars 9 forks source link

Escape double quotes in page titles in stork TOML file #15

Closed s3lph closed 1 year ago

s3lph commented 1 year ago

Pull Request Checklist

Resolves: https://github.com/pelican-plugins/search/issues/3#issuecomment-1186287268

Description

If a page title contains a double quote ("), the double quote is rendered into the stork toml file verbatim, creating a syntax error and causing stork to fail.

This PR escapes double quotes in titles (AFAICT this is the only place where they should appear) with \", fixing the syntax errors.

arbinada-com commented 1 year ago

This is a blocking bug that requires a user to modify plugin source code. Please merge it ASAP.

justinmayer commented 1 year ago

This change was superseded by #23 and released in v1.0.2. That said, thanks again for the fix, Sebastian!