pelican-plugins / search

Pelican plugin that adds site search capability
47 stars 9 forks source link

Installation fails due to version of rtoml dependency #38

Closed camillem closed 3 months ago

camillem commented 3 months ago

Issue

Hi,

When trying to pipx install the search plugin, it fails due to the required version of rtoml.

> pipx inject pelican pelican-search 
Fatal error from pip prevented installation. Full pip output in file:
    /home/camille/.local/pipx/logs/cmd_2024-06-15_18.51.26_pip_errors.log

pip seemed to fail to build package:
    rtoml<0.10.0,>=0.9.0

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    error: metadata-generation-failed
Error installing pelican-search.

Same error happens when directly trying with rtoml==0.9.0

> pipx inject pelican rtoml==0.9.0
Fatal error from pip prevented installation. Full pip output in file:
    /home/camille/.local/pipx/logs/cmd_2024-06-15_18.41.47_pip_errors.log

pip seemed to fail to build package:
    rtoml==0.9.0

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    error: metadata-generation-failed
Error installing rtoml from spec 'rtoml==0.9.0'.

But installation succeeds with version 0.10.0 :

> pipx inject pelican rtoml==0.10.0
  injected package rtoml into venv pelican
done! ✨ 🌟 ✨

(and actually if fails because cargo is not installed )

So, except if there is a reason not to switch to version 0.10.0, this could solve the problem, without requiring the installation of cargo. Thanks, Camille

justinmayer commented 3 months ago

I can't reproduce this:

~ ➤ pipx install --python 3.12.4 pelican
  installed package pelican 4.9.1, installed using Python 3.12.4
  These apps are now globally available
    - pelican
    - pelican-import
    - pelican-plugins
    - pelican-quickstart
    - pelican-themes
done! ✨ 🌟 ✨
~ ➤ pipx inject pelican pelican-search
  injected package pelican-search into venv pelican
done! ✨ 🌟 ✨

That said, I don't see any particular problem with removing the upper bound on the rtoml package dependency.

camillem commented 3 months ago

Thanks for the fast reply! I solved the problem by installing cargo and a few deps, so not worth spending more time on this, I guess.