search

pelican-plugins / sitemap

Generates a site map for Pelican-powered sites
50 stars 11 forks source link

Fix: Check exclusion of URLs for txt format #19

Closed georgkrause closed 1 year ago

georgkrause commented 1 year ago

The docs don't state that exclusion isn't available for txt, also I don't think this would make a lot of sense, its just a matter of the order of the conditions.

kernc commented 1 year ago

Sure! This bug fix looks valid.

The bug is also fixed by my PR https://github.com/pelican-plugins/sitemap/pull/3, which may look overwhelming, but in reality should improve everything. 😅 Is the CI/tests framework in place yet?

georgkrause commented 1 year ago

Maybe we can use my fix for a patch release and do the refactoring in a following release? I can also check you MR, however I wouldn't mind if this one can go quickly to production

justinmayer commented 1 year ago

@georgkrause: Seems sensible to me. As noted in the "How to Contribute" docs, would you please add a RELEASE.md file at the project root with the following contents?

Release type: patch

Enable URL exclusion when using `txt` format.
justinmayer commented 1 year ago

Hey Georg. Many thanks for your work on this. I merged the branch that @pR0Ps submitted via #16 in favor of this PR. The good news is that Sitemap 1.0.3 has been released, so please give the new plugin version a try and feel free to submit follow-up PRs if you find something that needs additional improvement.

Once again, many thanks! ✨

georgkrause commented 1 year ago

@justinmayer Sorry, I totally lost track of this. Thanks for taking care, I am going to tst 1.0.3!