search

pelkmanslab / CellProfilerPelkmans

A fork of CellProfiler1.0 developed by members of Pelkmans Lab https://www.pelkmanslab.org
GNU General Public License v2.0
1 stars 1 forks source link

Missing IlluminationCorrection* modules in documentation #12

Closed ewiger closed 8 years ago

ewiger commented 9 years ago

What is the latest status of IlluminationCorrection* modules in CPP

- loading pipeline
{Error using PreCluster_with_pipeline>LoadPipeline (line 204)
Could not find file IlluminationCorrection2D.m

Error in PreCluster_with_pipeline (line 45)
    handles = LoadPipeline(handles, LoadedSettings.Settings);%#ok Ignore MLint

I have noticed that there is no IlluminationCorrection module in the README.md Can we update it?

tstoeger commented 9 years ago

See issue #10 . Responsible people did not remove outdated CP modules, which is a source of potential errors and confusion.

In line with the original CP meeting (not iBrain meeting), I have deleted extra copies and outdated versions of modules (since they confused me while making pipelines - including for real experiments). In the specific case of IlluminationCorrection2D I manually compared the code differences to the new IlluminationCorrectionZScoring module, which contains all the functionality that is required (only functions which are obsolete and should be gone according to CP meeting are gone).

tstoeger commented 9 years ago

Where did the bug outlined above occur?

If (old?) pipeline on iBrain_Brutus has problem because of IlluminationCorrection2D, the pipeline should be updated to contain only the curated modules of CPP.

ewiger commented 9 years ago

@tstoeger please update the documentation. There is no information about IlluminationCorrectionZScoring Thank you!

tstoeger commented 9 years ago

I did not make IlluminationCorrectionZScoring and will not write documentation for it. See #5 .

tstoeger commented 8 years ago

just closing issue, where I have been mentioned, which in meantime is however fixed