search

pelle / oauth-plugin

Rails plugin for OAuth
http://stakeventures.com/articles/2009/07/21/consuming-oauth-intelligently-in-rails
MIT License
715 stars 215 forks source link

Library does not work with Rails 5.1 due to use of before_filter #157

Open kevinburkeomg opened 6 years ago

kevinburkeomg commented 6 years ago

If you try to include this library with Rails 5.1, you get the following error:

Failure/Error: include Oauth::Controllers::ConsumerController

NoMethodError:
  undefined method `before_filter' for OAuthConsumersController:Class
  Did you mean?  before_action
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:6:in `block in included'
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:5:in `class_eval'
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:5:in `included'
# ./app/controllers/oauth_consumers_controller.rb:3:in `include'
# ./app/controllers/oauth_consumers_controller.rb:3:in `<class:OAuthConsumersController>'
# ./app/controllers/oauth_consumers_controller.rb:2:in `<top (required)>'

before_filter was removed in Rails 5.1, so this library isn't compatible. It looks like #156 will fix the issue.

JorgeLAB commented 8 months ago

I believe t gem is no longer sustained.

t last commit,

image