search

pelle / oauth-plugin

Rails plugin for OAuth
http://stakeventures.com/articles/2009/07/21/consuming-oauth-intelligently-in-rails
MIT License
716 stars 216 forks source link

Rails3 #22

Closed alsemyonov closed 13 years ago

alsemyonov commented 13 years ago

I have modularized OauthProvider generator, added hooks for orm, test framework and template to make it more rails3y.

pelle commented 13 years ago

This looks really good. I haven't looked at how the hooks work. Do you see any issues with the consumer not being modularized?

The question is for example lib/generators/haml/templates. I'm thinking if it wouldn't be a good idea to do something like lib/generators/haml/oauth_provider_templates to make it simpler to modularize the consumer provider as well.

alsemyonov commented 13 years ago

I have not try to modularize OAuth client just now because I have not needed it right now. But I want to try to fix it later, when I will have some free time. If some templates are common for both provider and consumer generators, it is definitely better to put it in some common space, or just override template path for one of providers.