pelle / oauth-plugin

Rails plugin for OAuth
http://stakeventures.com/articles/2009/07/21/consuming-oauth-intelligently-in-rails
MIT License
716 stars 216 forks source link

Search for Oauth2Token that are authorized and not invalidated in the Rack middleware #78

Closed rymai closed 13 years ago

rymai commented 13 years ago

Hi,

First, thanks for this plugin!

I was surprised that when using OAuth::Controllers::ApplicationControllerMethods.oauthenticate, every token were valid for authentication, even the invalidated ones!

So I think this patch fix this (I've updated the specs). I've also simplified a condition in OAuth::Rack::OAuthFilter#oauth2_token and the Guardfile to remove the deprecation notice.

Thanks!

rymai commented 13 years ago

Any activity here? :)

pelle commented 13 years ago

Sorry I've been really busy. I'm merging it in now and creating a release.

pelle commented 13 years ago

Done. Thank you very much. An important fix.

rymai commented 13 years ago

Thanks very much and thanks for the plugin, that's a really useful bootstrap! :)