search

pelle / oauth-plugin

Rails plugin for OAuth
http://stakeventures.com/articles/2009/07/21/consuming-oauth-intelligently-in-rails
MIT License
716 stars 216 forks source link

Handle callbacks for OAuth 1.0 clients #99

Closed tomhughes closed 12 years ago

tomhughes commented 12 years ago

The merging of the oauth1 and oauth2 providers in 810348163121c6e446b2a4946671c2d12c4ede5f accidentally lost the code which handled callbacks for 1.0 clients. This commit restores that support.

pelle commented 12 years ago

OAuth 1.0 has a serious security issue, which was fixed in OAuth 1.0a. The current code correctly supports 1.0a, but I'd prefer not to have code that supports the insecure authorization model in the repo.

tomhughes commented 12 years ago

Well if you're not going to support it you should probably remove the explanation of how to enable it from the documentation ;-)

pelle commented 12 years ago

Thanks, that is actually a very good point.