pellepl / spiflash_driver

Hardware agnostic generic spi flash driver
MIT License
73 stars 27 forks source link

Padding bytes for the Read-ID command ? #9

Open g-berthiaume opened 3 months ago

g-berthiaume commented 3 months ago

Hi ! I'm trying to port your great library to the Microchip SST25PF040C SPI flash and I'm encountering a problem while using the SPIFLASH_read_product_id to read the product ID.

As you can see in the datasheet [1], it looks like the Read-ID command requires 3 padding bytes. The SpiFlash driver does not seem to support byte padding for this command.

image

(btw, it looks like the comment is wrong)

My question:

Is my flash abnormal, is this me using your library incorrectly or is this a bug?

Thanks for your time.


[1] Microchip SST25PF040C datasheet image

pellepl commented 3 months ago

Hi, the driver is correct - the 1 you marked is for sending the read-id command, then we read 3 bytes (the 3 you see afterwards). In fact, i believe I've used that spiflash with this repo before.

Cheers

Den fre 22 mars 2024 19:43G. Berthiaume @.***> skrev:

Hi ! I'm trying to port your great library to the Microchip SST25PF040C SPI flash and I'm encountering a problem while using the SPIFLASH_read_product_id to read the product ID.

As you can see in the datasheet [1], it looks like the Read-ID command requires 3 padding bytes. The SpiFlash driver does not seem to support byte padding for this command.

image.png (view on web) https://github.com/pellepl/spiflash_driver/assets/19377511/913fb24c-1438-416a-b4fe-e0adda581e3c

(btw, it looks like the comment is wrong) My question:

Is my flash abnormal, is this me using your library incorrectly or is this a bug?

Thanks for your time.

[1] Microchip SST25PF040C datasheet image.png (view on web) https://github.com/pellepl/spiflash_driver/assets/19377511/3e4f3d42-21b8-44a1-99ff-e05077e43167

— Reply to this email directly, view it on GitHub https://github.com/pellepl/spiflash_driver/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG42V4XW3Q6SYNPDKB2HMLYZR3T5AVCNFSM6AAAAABFD2DKOOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDGMBZG43DIMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>