IVAs are unscaled - Githubissues

pellinor0 / TweakScale

Forked from Gaius Goodspeed's Goodspeed Aerospace Part & TweakScale plugin

29 stars 23 forks source link

IVAs are unscaled #27

Closed pellinor0 closed 8 years ago

pellinor0 commented 8 years ago

This was always the case but becomes much more obvious with the new overlay.

The least breaking thing to do is probably to scale the IVAs - with the side effect of scaled kerbals.

There is the obvious solution of "then don't do it" but there are legitimate uses of scaled crew parts (like aircraft form factors that only offer a cockpit for the front). And generally the plugin needs to work if a TweakScale module ends up on a part with an IVA.

pellinor0 commented 8 years ago

"part.internalModel.transform.localScale *= ScalingFactor.absolute.linear;" seems to do the trick. Mostly.

For the MK1-2 pos the scale looks right. But for an upscaled MK1 pod the IVA gets too large. Maybe there is some part-dependent constant factor we need to include? Like part.(re)scaleFactor? Would be strange because the above line does a relative change in scale...
Doing a crew transfer resets the scale. not sure what would be the best way to deal with that. Is there an event to hook into? Where can I see if the IVA overlay is active?

pellinor0 commented 8 years ago

Writing the scale every frame works (but is probably not a good idea). Writing it at the OnCrewTransferred event does not work, so the reset probably happens afterwards.

pellinor0 commented 8 years ago

fixed by https://github.com/pellinor0/TweakScale/commit/a346b6a2191cc8c0cb94fc194ac1b63804ecb7de and the mk1 pod IVA being too large is actually a stock bug that does not need TweakScale to happen