Support for FSEngine Module

pellinor0 / TweakScale

Forked from Gaius Goodspeed's Goodspeed Aerospace Part & TweakScale plugin

29 stars 23 forks source link

Support for FSEngine Module #7

Closed pellinor0 closed 9 years ago

pellinor0 commented 9 years ago

Looking at the FSPROpeller part from firespitter, there are a couple of other modules that seem connected and may also need support for the part to scale well: FSpropellerTweak, FSalternator.

If I remember right, maxThrust only limits how much energy the motor produces. There is another limit how much energy the propeller can convert into thrust (probably in FSPropellerTweak).

How does fuelConsumption work? Do we need to scale that?

pellinor0 commented 9 years ago

Looking into https://github.com/snjo/Firespitter/blob/master/Firespitter/engine/FS%20engine%20modules/FSengine.cs (line 359), fuel consumption already scales with maxThrust, so there is nothing to scale.
since the thrust across the diverse firespitter propellers has no clear relation to propeller size I'll use an exponent of 2.5 to keep FSEngine consistent with the other engine modules.

pellinor0 commented 9 years ago

Done with https://github.com/pellinor0/TweakScale/commit/476f6ae228d3b5a544b64a1e44e5b505a5678d49 and https://github.com/pellinor0/TweakScale/commit/5be1cdcedf31bf3df137ed698e60af54adbba220.