pelmered / filament-money-field

Money field powered by Money PHP
MIT License
40 stars 19 forks source link

Adding documentation on methods and attributes. #17

Closed hiuryoliveira closed 4 months ago

hiuryoliveira commented 4 months ago

Hello my friend. I would like to congratulate you on the great work with this plugin. I would like to add some feature issues, and patterns that would be important in the use of my project.

My first contribution is adding documentation for methods and attributes.

pelmered commented 4 months ago

Thank you @hiuryoliveira! I'm normally not a fan of comments on all the methods and attributes as I think mostly just adds noise and clutter, and with type hints and good naming of the methods I find that they add little value. However, in an open source package like this one it might add some more value.

I'm willing to merge if you can make a good case for this.

hiuryoliveira commented 4 months ago

@pelmered, I reflected a little more on what you told me, and I have to agree. But what do you think if we add declare(strict_types=1) ?

pelmered commented 4 months ago

@hiuryoliveira Yes, strict types would be nice. I would accept an PR for that if it does not break anything.