pelotech / drone-helm3

Plugin for drone to deploy helm charts using helm3
Apache License 2.0
31 stars 36 forks source link

Remove the `prefix` setting #48

Closed ErinCall closed 4 years ago

ErinCall commented 4 years ago

The prefix setting in internal/helm/config.go exists because it existed in drone-helm. As I've learned more about drone usage, it's become clear it's not needed. It was meant to support a .drone.yml stanza like this:

pipeline:
  steps:
    - name: deploy_staging
      image: pelotech/drone-helm3
      prefix: stage
      secrets: [stage_kubernetes_token]

That secrets syntax is deprecated in recent versions of drone, and might not work at all. A modern stanza would look like this:

pipeline:
  steps:
    - name: deploy_staging
      image: pelotech/drone-helm3
      kubernetes_token:
        from_secret: stage_kubernetes_token