Better fix to undefined symbols. Compiles, runs and produces side1.cdt.

pelrun / dsk2cdt2disc

Convert CPC DSK files to a tape image that will rebuild the disc when loaded.

13 stars 3 forks source link

Better fix to undefined symbols. Compiles, runs and produces side1.cdt. #10

Closed cpcitor closed 7 years ago

cpcitor commented 7 years ago

Fix seems to actually fix #5 since it compiles and appears to actually work. Will test with an actual CPC.

The real CPC shows:

Loading LOADER block 1
Line too long
Ready

I think it's a different issue and basically it works far enough to validate this pull request since build now works, produces a binary that generates a CDT.

If you agree, please accept this pull request. Thank you.

pelrun commented 7 years ago

"Hang on, isn't that just changing it back the way it was?" was my reaction for a few seconds until I realised exactly what the original bug was.

I should probably be paying a bit more attention before merging changes. So I'll probably wait to merge anything more until tomorrow when I can build this myself. I think I've got a proper solution to the symbol name stuff now, so this will all probably change significantly. I'll look into getting travis CI properly configured too.

cpcitor commented 7 years ago

Yes, you're right. Writing toolchain-specific symbol names in header feels hackish.

pelrun commented 7 years ago

I've got this cleaned up now, so the hackish stuff is gone. Thanks though!