search

pelrun / dsk2cdt2disc

Convert CPC DSK files to a tape image that will rebuild the disc when loaded.
13 stars 3 forks source link

Compute output file name from input file name. #15

Closed cpcitor closed 2 years ago

cpcitor commented 2 years ago

When one wish to prepare several images in the same directory, (also on unattended workflows) this eliminates a cumbersome rename operation. And even if one operation is done, the file name makes it clear from which image the cdt was generated.

cpcitor commented 2 years ago

Added a commit to fix workflow fragility.

Github has probably updated the tool chain within the 14 months since latest build.

Indeed I can reproduce github's failure on my Ubuntu 20.04 by following .github/workflows/c-cpp.yml: x86_64-w64-mingw32-gcc generates an executable correctly, and it is already prefixed with .exe, so mv is not necessary.

export LC_ALL=C ; make clean ; ls -1b dsk2cdt.* ; CC=x86_64-w64-mingw32-gcc make 2>/dev/null >/dev/null ; ls -1b dsk2cdt.*

rm -f dsk2cdt *.a *.o *.exe *.bin ./thirdparty/exomizer/src/*.o ./thirdparty/2cdt/src/*.o
ls: cannot access 'dsk2cdt.*': No such file or directory
dsk2cdt.exe
dsk2cdt.o

For the sake of robustness (if someone tried those steps on an earlier configuration), keeping the mv step automatically optional.

pelrun commented 2 years ago

Run argv[1] through basename() first? The input argument can take a full path, after all.

cpcitor commented 2 years ago

Yes, you're right. Should go through basename() first. No time to do it now, may do it after a moment (a few weeks, maybe).

pelrun commented 2 years ago

I've done the basename change as well, seems ok on both linux and windows builds even though basename itself is weirdly defined...

I've done some other significant changes that may directly impact compatibility, so I need to sit down and do some testing before rolling out a new release.