pelrun / pyWinControls

Python version of GPD's WinControls for the GPD Win Mini and Win 4
GNU General Public License v3.0
28 stars 6 forks source link

[Bug] v1.0.3 Release binary: unable to parse config files with multiple lines #5

Open fsworld009 opened 2 months ago

fsworld009 commented 2 months ago

Environment: Bazzite OS on GPD Win 4 2023 Binary: the release binary in https://github.com/pelrun/pyWinControls/releases/tag/v1.0.3

Reproducable steps:

$ ./gpdconfig -d config.conf
$ ./gpdconfig -s config.conf
RuntimeError: Invalid key 'UP
'. Must be one of ['NONE', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', 'ENTER', 'ESC', 'BACKSPACE', 'TAB', 'SPACE', 'MINUS', 'EQUAL', 'LEFTBRACE', 'RIGHTBRACE', 'BACKSLASH', 'HASHTILDE', 'SEMICOLON', 'APOSTROPHE', 'GRAVE', 'COMMA', 'DOT', 'SLASH', 'CAPSLOCK', 'F1', 'F2', 'F3', 'F4', 'F5', 'F6', 'F7', 'F8', 'F9', 'F10', 'F11', 'F12', 'SYSRQ', 'SCROLLLOCK', 'PAUSE', 'INSERT', 'HOME', 'PAGEUP', 'DELETE', 'END', 'PAGEDOWN', 'RIGHT', 'LEFT', 'DOWN', 'UP', 'NUMLOCK', 'KPSLASH', 'KPASTERISK', 'KPMINUS', 'KPPLUS', 'KPENTER', 'KP1', 'KP2', 'KP3', 'KP4', 'KP5', 'KP6', 'KP7', 'KP8', 'KP9', 'KP0', 'KPDOT', '102ND', 'COMPOSE', 'POWER', 'KPEQUAL', 'F13', 'F14', 'F15', 'F16', 'F17', 'F18', 'F19', 'F20', 'F21', 'F22', 'F23', 'F24', 'OPEN', 'HELP', 'PROPS', 'FRONT', 'STOP', 'AGAIN', 'UNDO', 'CUT', 'COPY', 'PASTE', 'FIND', 'MUTE', 'VOLUMEUP', 'VOLUMEDOWN', 'KPCOMMA', 'RO', 'KATAKANAHIRAGANA', 'YEN', 'HENKAN', 'MUHENKAN', 'KPJPCOMMA', 'HANGEUL', 'HANJA', 'KATAKANA', 'HIRAGANA', 'ZENKAKUHANKAKU', 'KPLEFTPAREN', 'KPRIGHTPAREN', 'LEFTCTRL', 'LEFTSHIFT', 'LEFTALT', 'LEFTMETA', 'RIGHTCTRL', 'RIGHTSHIFT', 'RIGHTALT', 'RIGHTMETA', 'MOUSE_WHEELUP', 'MOUSE_WHEELDOWN', 'MOUSE_LEFT', 'MOUSE_RIGHT', 'MOUSE_MIDDLE', 'MOUSE_FAST']

It works if I manually make a config file with only one line.

Based on error message, it looks like there's an issue on parsing multiline text, and the parsed key for the lu becomes UP\n instead of UP

pelrun commented 2 months ago

Yeah. That's actually already fixed by #4, I just hadn't packaged it up into a new release. Will look at doing that asap.