pelzlpj / orpie

Curses-based RPN calculator
GNU General Public License v3.0
70 stars 5 forks source link

Fixing a couple minor niggles #11

Closed jared-wallace closed 6 years ago

jared-wallace commented 7 years ago

Adding this as an issue, because I suspect you won't be wanting to pull this for the same reason as #1.

Latest Fedora adds -Werror=implicit-function-declaration and Werror=implicit-int.

Following two patches are required now to build:

-- configure.orig› 2016-12-05 18:43:00.145119194 -0600                                                                                                                                                            
+++ configure›  2016-12-05 18:47:13.854860995 -0600                                                                                                                                                                
@@ -3138,6 +3138,7 @@                                                                                                                                                                                              
    cat confdefs.h - <<_ACEOF >conftest.$ac_ext                                                                                                                                                                    
 /* end confdefs.h.  */                                                                                                                                                                                            
 #include <gsl/gsl_complex.h>                                                                                                                                                                                      
+#include <gsl/gsl_complex_math.h>                                                                                                                                                                                 
 int                                                                                                                                                                                                               
 main ()                                                                                                                                                                                                           
 {    

and

--- gsl/mlgsl_blas.h.orig›  2016-12-05 19:19:53.297317617 -0600                                                                                                                                                    
+++ gsl/mlgsl_blas.h›   2016-12-05 19:20:23.895032460 -0600                                                                                                                                                        
@@ -2,31 +2,31 @@                                                                                                                                                                                                  
 /* Copyright (©) 2002-2005 - Olivier Andrieu                */                                                                                                                                                    
 /* distributed under the terms of the GPL version 2         */                                                                                                                                                    
•                                                                                                                                                                                                                  
-static inline CBLAS_ORDER_t CBLAS_ORDER_val(v)                                                                                                                                                                    
+static inline CBLAS_ORDER_t CBLAS_ORDER_val(int v)                                                                                                                                                                
 {                                                                                                                                                                                                                 
   CBLAS_ORDER_t conv[] = { CblasRowMajor, CblasColMajor };                                                                                                                                                        
   return conv[ Int_val(v) ];                                                                                                                                                                                      
 }                                                                                                                                                                                                                 
•                                                                                                                                                                                                                  
-static inline CBLAS_TRANSPOSE_t CBLAS_TRANS_val(v)                                                                                                                                                                
+static inline CBLAS_TRANSPOSE_t CBLAS_TRANS_val(int v)                                                                                                                                                            
 {                                                                                                                                                                                                                 
   CBLAS_TRANSPOSE_t conv[] = { CblasNoTrans, CblasTrans, CblasConjTrans };                                                                                                                                        
   return conv[ Int_val(v) ];                                                                                                                                                                                      
 }                                                                                                                                                                                                                 
•                                                                                                                                                                                                                  
-static inline CBLAS_UPLO_t CBLAS_UPLO_val(v)                                                                                                                                                                      
+static inline CBLAS_UPLO_t CBLAS_UPLO_val(int v)                                                                                                                                                                  
 {                                                                                                                                                                                                                 
   CBLAS_UPLO_t conv[] = { CblasUpper, CblasLower };                                                                                                                                                               
   return conv[ Int_val(v) ];                                                                                                                                                                                      
 }                                                                                                                                                                                                                 
•                                                                                                                                                                                                                  
-static inline CBLAS_DIAG_t CBLAS_DIAG_val(v)                                                                                                                                                                      
+static inline CBLAS_DIAG_t CBLAS_DIAG_val(int v)                                                                                                                                                                  
 {                                                                                                                                                                                                                 
   CBLAS_DIAG_t conv[] = { CblasNonUnit, CblasUnit };                                                                                                                                                              
   return conv[ Int_val(v) ];                                                                                                                                                                                      
 }                                                                                                                                                                                                                 
•                                                                                                                                                                                                                  
-static inline CBLAS_SIDE_t CBLAS_SIDE_val(v)                                                                                                                                                                      
+static inline CBLAS_SIDE_t CBLAS_SIDE_val(int v)                                                                                                                                                                  
 {                                                                                                                                                                                                                 
   CBLAS_SIDE_t conv[] = { CblasLeft, CblasRight };                                                                                                                                                                
   return conv[ Int_val(v) ];         
pelzlpj commented 6 years ago

Fixed in 1a2d225218213d850bdcd40ed87449c176690139 (by removing local copy of ocamlgsl).