Build failure on Fedora 29

pelzlpj / orpie

Curses-based RPN calculator

GNU General Public License v3.0

70 stars 5 forks source link

Build failure on Fedora 29 #14

Closed bowlofeggs closed 6 years ago

bowlofeggs commented 6 years ago

I'm not familiar with ocaml, but I wanted to report that orpie does not build on Fedora 29 (due to release in October):

$ make
ocamlopt.opt -c -pp camlp4o -I ./curses -I ./gsl -I ./units -thread big_int_str.ml
File "big_int_str.ml", line 27, characters 5-12:
Error: Unbound module Big_int
make: *** [Makefile:285: big_int_str.cmx] Error 2

This is with ocaml-4.07.0-3.fc30.x86_64.

jared-wallace commented 6 years ago

I was able to resolve this with two steps:

1) Explicit call to use "unsafe-string" 2) Requiring "ocaml-num-devel"

The first fix is required because ocaml switched the default from unsafe to safe, and the second was because the Num library was dropped from ocaml in favor of Zarith.

Both fixes are bandaids that do not address the underlying issues though.

pelzlpj commented 6 years ago

-unsafe-string is integrated into the build script with 1a2d225218213d850bdcd40ed87449c176690139. The ocaml-num-devel dependency will need to get resolved on Fedora's end (looks like it has already?).