search

pelzvieh / IPv6Droid

IPv6 tunnel client for use on Android
20 stars 5 forks source link

Error message on mistyped password very cryptic #11

Closed pelzvieh closed 9 years ago

pelzvieh commented 10 years ago

Users with a mis-typed password will get the following error:

"This configuration will not work on this device"

This message is not self-explaining at all; especially in case of config mistakes, the error handling needs to be refined.

Original comment by: pelzi

pelzvieh commented 10 years ago

The problem here is that the exception comes out of a very generic method, Tic.requestResponse and is basically representing the fact, that the TIC server answered with a non-success status code (line 287 of Tic.java). This specific exception should be flagged internally by a suitable subclass of ConnectionFailedException in method Tic.protocolStepSendAuthentication, that will be checked for in VpnThread.run(). A non-success return code at this specific phase of the protocol is almost certainly related to a wrong user name or password.

Original comment by: pelzi

pelzvieh commented 10 years ago

Original comment by: pelzi

pelzvieh commented 10 years ago

Fixed in version 6 (1.02).

Original comment by: pelzi