search

pemiluAPI / peta-caleg

design & development of a candidate map for Indonesia's 2014 legislative elections
1 stars 4 forks source link

Use spinjs for whell spin icon and trivial format loading message. #44

Closed ykt closed 10 years ago

ykt commented 10 years ago

These changes is for this issue https://github.com/pemiluAPI/peta-caleg/issues/38

shawnbot commented 10 years ago

Thank you, Yasir!

This is helpful, but I'd like it to be better integrated into the PetaCaleg.App class, rather than there being a single private Spinner instance and a hard-coded element reference. Another way to do it would be to have the App class dispatch "loading" and "loaded" events, and do the spinner-related stuff right in index.html, to remove the dependency on spinjs from the core code.

I started working on a progress bar (see 8345cddcdc5e34387dc857ccf3ef11c37866b61e, 8345cddcdc5e34387dc857ccf3ef11c37866b61e and 2fdbc6b6a98fb28f18946657dc37251b007f2d7d—I had to disable it for now, though) and would prefer to hook that up to reflect more accurate loading progress.

ykt commented 10 years ago

Agree on this, let me see what I can do with those unused progress function from you commits.

ykt commented 10 years ago

Hi, It is using d3 events, for JSON requests. it might be not the best solution, but it shows progress wheel during JSON submission.

Thanks.

shawnbot commented 10 years ago

Worked out using Bootstrap progress bars in #38. Thank you!