Closed tmaybe closed 10 years ago
Additionally (or instead) put the mini-logo of the top vote-getting party at the centroid(?) of the province or dapil.
I'm working on the mini flags now.
OK, so I have a fix incoming for this, but I have a question about the "top vote-getting party". Right now I'm using the total number of votes for elected candidates, but I'm not sure if that's right. Should it just be the total number of votes for all of a party's candidates?
I think it should be votes for elected candidates, at least to start. That seems more 'accurate' to me (though it's kind of arbitrary) because votes for a candidate that didn't win are in some sense votes that didn't affect the outcome.
On Wednesday, June 25, 2014, Shawn Allen notifications@github.com wrote:
OK, so I have a fix incoming for this, but I have a question about the "top vote-getting party". Right now I'm using the total number of votes for elected candidates, but I'm not sure if that's right. Should it just be the total number of votes for all of a party's candidates?
— Reply to this email directly or view it on GitHub https://github.com/pemiluAPI/peta-caleg/issues/64#issuecomment-47177111.
Sweet, we're good then. How do you like the flags? I also fixed a bug that we hadn't caught before, in which the provinces weren't changing when you switch between DPR and DPD.
I like them a lot! I submitted the latest build for review. I may try coloring the provinces/dapil in addition to the flags, just to see how it looks, but I think it works great as is.
Associate a primary color with each party and use it to tint province/dapil on the DPR map. The colors should reflect the party that received the most votes in that province/dapil.