search

pemistahl / lingua-go

The most accurate natural language detection library for Go, suitable for short text and mixed-language text
Apache License 2.0
1.16k stars 65 forks source link

Put resources into compiled binary #3

Closed dsxack closed 3 years ago

dsxack commented 3 years ago

Resources not be available from compiled binary and this does not allow using the module without put language-models near compiled binary.

It fixes https://github.com/pemistahl/lingua-go/issues/2

codecov[bot] commented 3 years ago

Codecov Report

Merging #3 (0041846) into main (61c7054) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files           8        8           
  Lines        1187     1187           
=======================================
  Hits          937      937           
  Misses        189      189           
  Partials       61       61
Impacted Files Coverage Δ
json.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61c7054...0041846. Read the comment docs.

pemistahl commented 3 years ago

Thank you very much for the fix @dsxack. :)

dsxack commented 3 years ago

Thank you for merge @pemistahl :-)