search

pemistahl / lingua-go

The most accurate natural language detection library for Go, suitable for short text and mixed-language text
Apache License 2.0
1.18k stars 66 forks source link

support Malayalam #53

Open Casxt opened 10 months ago

Casxt commented 10 months ago

Hi @pemistahl, I'm happy to add a new language to this amazing project. I've carefully followed the SOP for adding a new language, and everything looks good. However, I've noticed a slight change in the whatlang output, pls kindly check this if needed.

pemistahl commented 10 months ago

Thanks a lot for this PR. I will need some time to review it but I will get back to you as soon as I'm done with it.

pemistahl commented 10 months ago

@Casxt Some unit tests have failed. Can you fix them please?

Casxt commented 10 months ago

@Casxt Some unit tests have failed. Can you fix them please?

Hi @pemistahl, ut should be fixed

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b30f17c) 87.48% compared to head (d4286db) 87.43%.

Files Patch % Lines
alphabet.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== - Coverage 87.48% 87.43% -0.05% ========================================== Files 8 8 Lines 1598 1608 +10 ========================================== + Hits 1398 1406 +8 - Misses 147 149 +2 Partials 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.