search

pemistahl / lingua-py

The most accurate natural language detection library for Python, suitable for short text and mixed-language text
Apache License 2.0
1.02k stars 43 forks source link

Add fastspell conservative and agressive to the comparison #190

Closed marco-c closed 7 months ago

marco-c commented 8 months ago

Fixes #188

marco-c commented 8 months ago

The PR is marked as draft because Poetry is failing to install the package.

marco-c commented 7 months ago

I managed to find a way to fix the installation error. With Python 3.10, which I'm using, we need to install at least cyhunspell 2.0.3 (which isn't published on PyPI yet).

pemistahl commented 7 months ago

Thank you Marco. I will deal with your PR shortly. MyPy is reporting type checking failures. Can you fix them please?

pemistahl commented 7 months ago

You always need to run the Black code formatter as well, please. Otherwise, the build fails.

marco-c commented 7 months ago

Yeah, I'm too used to my projects where mypy, black and other linting are run on a commit hook :)