Open kareglazie opened 6 months ago
Hi Svetlana,
thank you for your effort to enhance my library with more languages. This is great. :) Can you please open a pull request? Then it's easier to review your changes and additions and to comment on them.
As for Norwegian, I prefer to treat Bokmal and Nynorsk separately because they are basically two different variants of written Norwegian. I want my library to be able to differentiate between them.
Hello! Thanks for your reply. I've opened the PR and removed general Norwegian from models (now there are two separate variants, as it was originally in your crate).
Hello,
Thank you for your great Lingua crate!
As part of our efforts to adapt Lingua for our production environment and requirements, we've been working on extending its language support. We believe these enhancements can also be beneficial for the wider Lingua community and would like to participate in mainstream development by contributing our changes.
Added Language Models
We have introduced models for the following languages:
Norwegian Language Model Consideration
Additionally, during our development, we identified the need to consolidate the Norwegian language models. Originally, Lingua supports both Bokmål and Nynorsk. However, for our specific use case, a singular Norwegian model proved to be more effective. Therefore, we've replaced Bokmål with a more general Norwegian model in our branch.
This change raises an important question for the Lingua project: Would there be interest in adding a unified Norwegian model alongside the existing Bokmål and Nynorsk models, or would you prefer maintaining the distinct form of Norwegian as currently represented by Bokmål and Nynorsk? We're open to reverting our Norwegian model to separate Bokmål and Nynorsk models to align with your preferences.
Here's the link to our branch: https://github.com/kareglazie/lingua-rs/tree/new-langs