search

pemistahl / lingua

The most accurate natural language detection library for Java and the JVM, suitable for long and short text alike
Apache License 2.0
706 stars 63 forks source link

Improve `addMainModuleInfo` task configuration #150

Closed Marcono1234 closed 2 years ago

Marcono1234 commented 2 years ago

Removes version = because it seems to reassign the project version instead of configuring the task (the task has no setter for the module info version, it uses the project version) (see https://github.com/moditect/moditect-gradle-plugin/issues/16).

Manually specifies the project JAR as input because the task erroneously does not do that itself (https://github.com/moditect/moditect-gradle-plugin/pull/17). Previously this could lead to incorrect UP-TO-DATE results for addMainModuleInfo where the module descriptor was not added to the JAR.

pemistahl commented 2 years ago

Thank you, @Marcono1234. Your changes look reasonable to me.